Implement Send for Stream on certain platforms
#840
+27
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As a small test, the pub fn run<T>(device: &cpal::Device, config: &cpal::StreamConfig) -> Result<(), anyhow::Error>
where
T: SizedSample + FromSample<f32>,
{
// snip
// Create the stream on the main thread...
let stream = device.build_output_stream(
config,
move |data: &mut [T], _: &cpal::OutputCallbackInfo| {
write_data(data, channels, &mut next_value)
},
err_fn,
None,
)?;
// ...then send it to a new thread and play it...
let stream = std::thread::spawn(move || {
stream.play()?;
std::thread::sleep(std::time::Duration::from_millis(1000));
Ok::<_, anyhow::Error>(stream)
});
// ...get it back and then pause and play it again.
let stream = stream.join().unwrap()?;
stream.pause()?;
std::thread::sleep(std::time::Duration::from_millis(1000));
stream.play()?;
std::thread::sleep(std::time::Duration::from_millis(1000));
Ok(())
} |
|
is there anyway we can get this merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
SendforStream#818Solution
Moved
NotSendSyncAcrossAllPlatformsinto its own module,maybe_send(for clarity) and implementedSendfor an instance where (I believe) it is safe to do so. I've deliberately left thecfgstatement controlling this implementation verbose to make it clear how other platforms could be included where it is confirmed to be safe to do so:To add this support to Linux but only on FreeBSD using Jack (as an example) then a single statement can be added without modifying any of the others:
I have deliberately only implemented
Sendon Windows under WASAPI in this pull request as I believe it is known to beSendsafe and should be relatively straight-forward to test. I would encourage others to test on platforms they can also confirm the behaviour on and then make follow-up PRs to increase support.Motivation
I personally ran into this issue myself when working with Bevy and thought it was a little annoying. Not a deal breaker by any stretch of the imagination, the workarounds are well documented and perfectly reasonable. This is more of a quality of life improvement than anything else.